Fix on focus config check #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 2b69eb1 in 32 seconds. Click for details.
- Reviewed
18lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. UnityMcpBridge/Editor/Windows/UnityMcpEditorWindow.cs:59
- Draft comment:
OnFocus now checks only the selected client instead of iterating over all clients. Confirm this change meets the intended behavior and that skipping other clients won’t cause issues. Consider adding a comment to clarify the rationale. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =20%<= threshold50%The comment asks the PR author to confirm their intention and ensure the behavior is intended, which violates the rules. However, it also suggests adding a comment to clarify the rationale, which is a valid suggestion. Overall, the comment is mostly about confirming intention, which is not allowed.
Workflow ID: wflow_SpnVqBOqL0yYC2Q5
You can customize 
Collaborator
|
@dsarno Looks good to me! Let me know what you think on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://discord.com/channels/1394050967917428756/1396128287771590757/1401040388541648998
Prevents the log spam, slightly more efficient check when the Window is back in focus.
This change was added very recently in #175, maybe check with the author first before merging this in, it continues to work for my connection but I'm not sure if this unwittingly breaks something. Feels safe so far
Important
Optimizes
OnFocus()inUnityMcpEditorWindow.csto prevent log spam by validatingselectedClientIndexbefore configuration checks.OnFocus()inUnityMcpEditorWindow.csby checking ifselectedClientIndexis valid before callingCheckMcpConfiguration().selectedClientIndexis within bounds.This description was created by
for 2b69eb1. You can customize this summary. It will automatically update as commits are pushed.